some type safety for Fix
#57314
Closed
some type safety for Fix
#57314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disallows any type `Fix{x}` where `!(x isa Int) || (x < 0)`.
Follows up on PR JuliaLang#54653.
The goals are similar as in the closed PR JuliaLang#56518, but less ambitious.
I hope it's not too late in the release cycle to consider this change
as it seems not to be invasive or disruptive.
|
This PR leaves a kind of hole, in that negatives are disallowed by subtyping for the value of the type parameter, but zero is only disallowed by the constructor method. This could hypothetically be patched in a future PR by changing the offset from one-based to zero-based, however that seems like it'd be less worthwhile, so it makes sense to leave it for the future, if this one gets merged. Even with the hole, this change is an improvement IMO, seeing as it makes expressions like |
nsajko
commented
Feb 8, 2025
vtjnash
requested changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallows any type
Fix{x}where!(x isa Int) || (x < 0).Follows up on PR #54653.
The goals are similar as in the closed PR #56518, but less ambitious.
I hope it's not too late in the release cycle to consider this change as it seems not to be invasive or disruptive.